Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render loading indicator on no results page #3652

Merged
merged 1 commit into from Mar 28, 2017
Merged

Render loading indicator on no results page #3652

merged 1 commit into from Mar 28, 2017

Conversation

edmundoa
Copy link
Contributor

Fixes #3650

I will backport the change to 2.2.3 once the PR is merged.

@edmundoa edmundoa added this to the 2.3.0 milestone Mar 24, 2017
joschi
joschi approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@joschi joschi self-assigned this Mar 28, 2017
@joschi joschi merged commit f975e7b into master Mar 28, 2017
@joschi joschi deleted the issue-3650 branch March 28, 2017 14:33
edmundoa added a commit that referenced this pull request Mar 28, 2017
@edmundoa
Render loading indicator on no results page (#3652)
6d0cdb3 
Fixes #3650
(cherry picked from commit f975e7b)
@edmundoa edmundoa mentioned this pull request Mar 28, 2017
Merged
joschi pushed a commit that referenced this pull request Mar 28, 2017
@edmundoa @joschi
Render loading indicator on no results page (#3667)
448d032 
Fixes #3650
Refs #3652
(cherry picked from commit f975e7b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschi joschi joschi approved these changes

Assignees

@joschi joschi

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edmundoa @joschi