Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelisting additional SentinelOne dylib pattern #3498

Merged

Conversation

lbergelson
Copy link
Contributor

It seems like SentinelOne is now using dylibs that include a number, possibly randomized in some way.
This causes brew doctor to give a warning, but it should probably be ignored like the previous versions of the sentinel dylib. (It was originally whitelisted here #1440)

updating diagnostic.rb to include a new pattern to ignore dylibs of the form sentinel-*.dylib

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

it seems like SentinelOne is now using dylibs that include a number, possibly randomized in some way
this causes brew doctor to give a warning, but it should probably be ignored like the previous versions of the sentinel dylib

updating diagnostic.rb to include a new pattern to ignore dylibs of the form sentinel-*.dylib
@MikeMcQuaid
Copy link
Member

Thanks for your first contribution to Homebrew, @lbergelson! Without people like you submitting PRs we couldn't run this project. You rock!

@MikeMcQuaid MikeMcQuaid merged commit 2b7788d into Homebrew:master Nov 29, 2017
@lbergelson
Copy link
Contributor Author

@MikeMcQuaid Thank you!

@lbergelson lbergelson deleted the lb_add_sentinel_one_whitelist branch November 29, 2017 15:33
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants