Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fewer default_max_warnings #1084

Closed
wants to merge 1 commit into from
Closed

fewer default_max_warnings #1084

wants to merge 1 commit into from

Conversation

adienes
Copy link

@adienes adienes commented May 2, 2023

addresses #1083

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (b3b717a) 90.22% compared to head (e5158e5) 90.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   90.22%   90.26%   +0.04%     
==========================================
  Files           9        9              
  Lines        2271     2271              
==========================================
+ Hits         2049     2050       +1     
+ Misses        222      221       -1     
Impacted Files Coverage Δ
src/CSV.jl 70.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@quinnj
Copy link
Member

quinnj commented Jun 3, 2023

You can control this via the maxwarnings keyword arg, so I don't think this change is as necessary.

@quinnj quinnj closed this Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants