Skip to content

Commit

Permalink
Fixed issue #15239: Brute-force attack with tokens to enter survey is…
Browse files Browse the repository at this point in the history
… possible (#1794)

Intentionally don't reset FailedLoginAttempt after token usccesfull validation
  • Loading branch information
gabrieljenik committed Mar 5, 2021
1 parent 4367fec commit 9cab67f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion application/helpers/frontend_helper.php
Expand Up @@ -1269,7 +1269,8 @@ function testIfTokenIsValid(array $subscenarios, array $thissurvey, array $aEnte
$aEnterTokenData['visibleToken'] = $clienttoken;
$aEnterTokenData['token'] = $clienttoken;
$renderToken = 'correct';
FailedLoginAttempt::model()->deleteAttempts();
// Intentionally don't reset FailedLoginAttempt for this IP.
// FailedLoginAttempt::model()->deleteAttempts();
}
}

Expand Down

0 comments on commit 9cab67f

Please sign in to comment.