-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dkijania/add test to ci #15641
Draft
dkijania
wants to merge
2,751
commits into
berkeley
Choose a base branch
from
dkijania/add_test_to_ci
base: berkeley
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dkijania/add test to ci #15641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_gen_in_nightly Introduce Hardfork Generation Nightly Test
…promotion_docs Fix promote pipeline docs issues
…rtifact upload script. Used BUILDKITE_ARTIFACT_UPLOAD_DESTINATION env which is available in each agent instead of hardcoded
Fix: don't use step feature_flags for wrap evaluations
…-printing-2 Omit git branch in node status/error reports
…ache_debs_via_buildkite_orginal
Depend on camlp-streams to remove the deprecation alert on Caml.Streams
Fix Stream deprecation warning
…g_again Bring back DEB_REPO argument for docker image build
…d_channel_ci_dev another port fix tags and channel ci [develop]
125c865
to
87ef481
Compare
87ef481
to
5d7370f
Compare
!ci-build-me |
!ci-toolchain-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome 👋
Thank you for contributing to Mina! Please see
CONTRIBUTING.md
if you haven'tyet. In that doc, there are more details around how to start our CI.
If you cannot complete any of the steps below, please ask for help from a core
contributor.
Incomplete Work
We feel it's important that everyone is comfortable landing incomplete projects
so we don't keep PRs open for too long (especially on develop). To do this we
don't want to forget that something is incomplete, don't want to be blocked on
landing things, and we don't want to land anything that breaks the daemon. We
don't want to forget to test the incomplete things whenever they are completed,
and finally we want to clean up after ourselves: any temporary cruft gets
completely removed before a project is considered done.
To achieve the above, we wish to keep track of incomplete work using a draft of
the release notes. We can share this part of the current draft at anytime with
external contributors. Moreover, we will review this draft during hardforks.
To ship incomplete work, put it behind feature flags -- prefer a runtime
CLI/daemon-config-style flag if possible, and only if necessary fallthrough to
compile time flags. Note that if you put code behind a compile time flag, you
must ensure that CI is building all possible code paths. Don't land something
that doesn't build in CI.
PLEASE DELETE EVERYTHING ABOVE THIS LINE
Explain your changes:
*
Explain how you tested your changes:
*
Checklist: