Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] base_tier_validation: Exclude cancel records from pending count #729

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[FIX] base_tier_validation: Exclude cancel records from pending count #729

merged 1 commit into from
Oct 10, 2023

Conversation

OpenCode
Copy link
Contributor

@OpenCode OpenCode commented Oct 10, 2023 •
edited

Fix #728

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@OpenCode OpenCode mentioned this pull request Oct 10, 2023
Closed
6 tasks
LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been able to reproduce in local and test your fix. LGTM

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-729-by-LoisRForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b10b01c into OCA:16.0 Oct 10, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e8a26b2. Thanks a lot for contributing to OCA. ❤️

@OpenCode OpenCode deleted the 16.0-fix_cancel_records_count branch October 16, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OpenCode @OCA-git-bot @LoisRForgeFlow