Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POEM 81: Implement Submodel Component #2817

Merged
merged 160 commits into from May 25, 2023
Merged

POEM 81: Implement Submodel Component #2817

merged 160 commits into from May 25, 2023

Conversation

nsteffen
Copy link
Contributor

@nsteffen nsteffen commented Feb 21, 2023 •
edited

Summary

POEM 81 implementation. Adds SubmodelComp as a new component allowing for users to evaluate OpenMDAO systems within a component.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

nsteffen and others added 17 commits February 14, 2023 11:42
@nsteffen
Subproblem implementation attempt
85bb643
@nsteffen
Changed how model is passed to problem and fixed displaying n2
023daf6
@nsteffen
cleaned up comments and check final value
bf76c3a
@nsteffen
Cleaned up code and made more descriptive comments
9da0758
@nsteffen
Cleaned up example code and SubproblemComp
e212108
@nsteffen
changed args for SubproblemComp
0f512bc
@nsteffen
Merge pull request #9 from nsteffen/subprob_test
ec5d6bc 
changed args for SubproblemComp
@nsteffen
moved SubproblemComp and changed init args
59db55f
@nsteffen
added default behavior for io
ac7867f
@nsteffen
added star option for io
79a33fa
@nsteffen
clarified io comment
1de5d39
@nsteffen
changed io behavior back
d2a7fbb
@nsteffen
changed example to specify io
ab37ce0
@nsteffen
changed io behavior for both comp and example
7664e2c
@nsteffen
updated with changes from POEM
4ccbd4e
@nsteffen
changed dirs/naming and updated from POEM081
ed2891b
@nsteffen
made get_model_vars and updated setup and doc strings
2b08823
@nsteffen nsteffen changed the title Subprob POEM 81: Implement Subproblem Component Feb 21, 2023
@swryan swryan added Pending POEM Acceptance Do not merge. This PR is attached to a POEM that is not yet accepted. POEM Indicates an issue/PR that references a POEM labels Feb 21, 2023
naylor-b
naylor-b requested changes Feb 21, 2023
View reviewed changes
openmdao/components/subproblem_comp.py Outdated Show resolved Hide resolved
openmdao/components/subproblem_comp.py Outdated Show resolved Hide resolved
openmdao/components/tests/test_subproblem_comp.py Outdated Show resolved Hide resolved
Kenneth-T-Moore
Kenneth-T-Moore approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@Kenneth-T-Moore Kenneth-T-Moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, simple, and concise. The only thing missing is a feature doc, which you could do as a follow-on.

@nsteffen nsteffen marked this pull request as ready for review May 10, 2023 19:01
naylor-b
naylor-b requested changes May 10, 2023
View reviewed changes
openmdao/components/submodel_comp.py Outdated Show resolved Hide resolved
@nsteffen nsteffen requested a review from naylor-b May 11, 2023 16:10
@swryan swryan removed the Pending POEM Acceptance Do not merge. This PR is attached to a POEM that is not yet accepted. label May 24, 2023
@swryan swryan merged commit e97160b into OpenMDAO:master May 25, 2023
8 checks passed
@relf relf mentioned this pull request Jun 30, 2023
Merged
@relf
Copy link
Contributor

relf commented Jun 30, 2023

Just to let you know this one is missing in the release notes.

@swryan swryan mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kenneth-T-Moore Kenneth-T-Moore Kenneth-T-Moore approved these changes

@relf relf relf left review comments

@robfalck robfalck robfalck approved these changes

@naylor-b naylor-b naylor-b approved these changes

Assignees
No one assigned
Labels
POEM Indicates an issue/PR that references a POEM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement POEM 81
7 participants
@nsteffen @coveralls @relf @robfalck @naylor-b @Kenneth-T-Moore @swryan