【Hackathon No.18】为 Paddle 新增 frexp #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PommesPeter
changed the title
|
如果可以的话，请修改一下rfc，基于现有paddle python api来实现frexp哈 @PommesPeter |
好的 感谢回复，我修改一下 |
tizhou86
reviewed
Jul 19, 2022
| ### 实现方法 | ||
|
|
||
| 在实现方法上，PyTorch 是通过 C++ API 实现的，[代码位置](https://github.com/pytorch/pytorch/blob/caee732aa1632e90074a00f89b99ed5f5dbc0dbd/aten/src/ATen/native/UnaryOps.cpp#L786-L792) | ||
|
|
There was a problem hiding this comment.
在实现层方面，可以考虑采用现有paddle log以及devide组合的方式来实现对应的功能，可以减少直接编写kernel的负担。
|
@PommesPeter hi，设计文档还有在修改吗？ |
|
该任务提案已被其他开发者完成 #214 ，此pr关闭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为 Paddle 新增 frexp