Smart resource pack parsing for file drops / opens #481
Conversation
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
Co-authored-by: Rachel Powers <508861+Ryex@users.noreply.github.com> Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
ryanccn
changed the title
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This makes it easier to validate individual resources, and allows the logic to be used in other places in the future, if we need to. Signed-off-by: flow <flowlnlnln@gmail.com>
They may not hold true at all times, and that's fine. Signed-off-by: flow <flowlnlnln@gmail.com>
There was a problem hiding this comment.
I've added a couple commits to take the logic you implemented into a separate thing, so that we can maybe fix #349 with it later on.
The instance names get cut off when they're too long. I believe that's the same issue we had with icon names at one point, so maybe there's something there to help fix this :p
|
Seems like the same issue still exists with icon names O.o I copied |
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
Signed-off-by: flow <flowlnlnln@gmail.com>
There was a problem hiding this comment.
how do you use that with CLI? -I open the modpack import thingy, so I guess that's not it 🧐
This looks cool. It would perhaps be cooler, though, if there was some info on the RP/TP in the dialog. Perhaps an InfoFrame on the top area would look good :>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Otherwise isLocalFile() will return false for local files without the file:// thingy. Signed-off-by: flow <flowlnlnln@gmail.com>
This PR parses files opened via XDG, Finder, CLI, or drag and drop to check if they are resource packs, and opens a dialog to import it into an instance if it is one. Otherwise, it falls back to the original instance importing behavior in #229.
Signed-off-by: Ryan Cao 70191398+ryanccn@users.noreply.github.com