Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Improve permissions check on oauth-apps endpoints #32338

Merged
merged 8 commits into from May 9, 2024

Conversation

matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Apr 30, 2024

Proposed changes (including videos or screenshots)

  • Improve permissions check on oauth-apps endpoints by using the permissionsRequired property.

Issue(s)

CORE-344

Steps to test or reproduce

Further comments

The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.

@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Apr 30, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: e59ca2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.71%. Comparing base (c68e1e8) to head (e59ca2e).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #32338      +/-   ##
=================================================
- Coverage          55.74%   55.71%   -0.03%     
=================================================
  Files               2406     2407       +1     
  Lines              52926    52932       +6     
  Branches           10871    10873       +2     
=================================================
- Hits               29501    29492       -9     
- Misses             20817    20832      +15     
  Partials            2608     2608              
Flag Coverage Δ
e2e 54.73% <ø> (-0.04%) ⬇️
unit 73.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review April 30, 2024 12:54
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner April 30, 2024 12:54
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners May 7, 2024 13:39
@MarcosSpessatto MarcosSpessatto removed request for a team May 9, 2024 18:36
@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label May 9, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 9, 2024
@matheusbsilva137 matheusbsilva137 merged commit c5bf0fc into release-7.0.0 May 9, 2024
44 of 45 checks passed
@matheusbsilva137 matheusbsilva137 deleted the chore/permissions-check-oauth-apps branch May 9, 2024 20:48
ggazzo pushed a commit that referenced this pull request May 9, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo pushed a commit that referenced this pull request May 15, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants