-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't add fullname tag in 2GP package.xml #3416
Conversation
@leboff I'm ... very surprised that this works, but I should have long since given up being surprised by the need for such tweaks! A few questions for you, as I think I will probably need to discuss this change with the Packaging team to fully understand the impact and expected behavior.
Thank you for your efforts in investigating and addressing this subtle issue. |
@davidmreed thanks for looking into it. Answers below
Managed + Namespaced
Yes
Yes, I use a forked version of CCI with this change and have close to 10 2GP packages promoted and in many production environments with this change applied |
@leboff Fascinating. I'll check in with my colleagues on Packaging to help me understand what's happening here. Using There is a related, known bug where packaging a One last question - are your repos in SFDX metadata format? |
Sorry, further last question: have you ever tried to upload a package version with this structure using SFDX directly? If so, what behavior did you see? |
yes
I think that's how I found the issue. Comparing the zip sfdx CLI used (which worked) and the zip CCI used (which did not) |
Thank you again for the exceptional detail and research here! |
Is there an ETA on release of the fix? |
Please fix this. While nice to name your packages, it completely breaks any ability to deploy tweaks or updates to metadata that is in a package. Interestingly, the same bug/limitation also affects change sets. |
I am currently running into an issue where this is preventing me from creating new 2GP Unlocked package without a namespace. My package has a quick action in it that references a namespaced (2gp unlocked also) lwc and it fails with
Please merge and fix this |
Fixed in #3636 |
@jstvz sorry for commenting on this closed PR. We are currently experiencing this issue as well and it is citically blocking our progress while developing 2GP packages. Context:
We understand there might be larger implications of @leboff 's fix, but we are not able to move forward while the issue persists. Thanks in advance! mentioning @winterrk and @yippie to check-in if they still experience the issue as well. |
@leboff thanks for your answer, the initial effort to figure it out and the new PR! Really appreciate it. |
Fixes #3415