Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add fullname tag in 2GP package.xml #3748

Merged
merged 8 commits into from May 14, 2024

Conversation

leboff
Copy link
Contributor

@leboff leboff commented Feb 15, 2024

Fixes #3415 for the scenario of when building a locked 2GP

@leboff leboff requested a review from a team as a code owner February 15, 2024 18:09
Copy link

Thanks for the contribution! It looks like @leboff is an internal user so signing the CLA is not required. However, we need to confirm this.

@pasres
Copy link

pasres commented Apr 11, 2024

We are experiencing the same issue and would really appreciate if this could be checked and hopefully merged soon.
I commented on @leboff 's other PR here: #3416 (comment)

@agaudoncr
Copy link

We are also experiencing this issue and would really appreciate it if this could be looked into and hopefully merged.

@agaudoncr
Copy link

For additional context, we received the following response from Salesforce Support indicating that this is the root of the problem.

CumulusCI creates the package version request it converts from SFDX to MDAPI and puts a package name (<fullName> tag) in the package.xml file. Could you please check the package.xml file of the project (manifest/package.xml) and see if that tag is being added? If so please try removing the tag and create the package.

Copy link
Contributor

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leboff Thank you for the fix, and apologies for the delay in getting it reviewed.

@jstvz jstvz merged commit a66bfe3 into SFDO-Tooling:main May 14, 2024
37 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating 2GP version in Winter '23
5 participants