Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bc dependency to ceph spec #85

Merged
merged 1 commit into from Feb 10, 2017
Merged

Add bc dependency to ceph spec #85

merged 1 commit into from Feb 10, 2017

Conversation

kshtsk
Copy link

@kshtsk kshtsk commented Feb 8, 2017

The bc is missing for ceph-helpers.sh

@ddiss
Copy link

ddiss commented Feb 8, 2017

Please propose this change in the upstream spec file.
This dependency should only be added if ceph_test_package is set, right?

@smithfarm
Copy link

@ddiss: note that ceph_test_package is a downstream-only thing, and this is needed for run-make-check.sh to succeed in SLE-12-SP2

@smithfarm
Copy link

@kshtsk Needs Signed-off-by: line (use "git commit -s" after configuring)

@kshtsk
Copy link
Author

kshtsk commented Feb 9, 2017

Added PR upstream: ceph#13338

@kshtsk kshtsk added duplicate and removed duplicate labels Feb 9, 2017
@smithfarm smithfarm changed the title Add bc dependency to ceph spec [DNM] Add bc dependency to ceph spec Feb 9, 2017
@smithfarm
Copy link

Marked DNM until upstream PR is merged

The bc is missing for ceph-helpers.sh

Fixes: http://tracker.ceph.com/issues/18876
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>
(cherry picked from commit 3ff4be6)
@smithfarm smithfarm changed the title [DNM] Add bc dependency to ceph spec Add bc dependency to ceph spec Feb 10, 2017
@smithfarm smithfarm self-requested a review February 10, 2017 11:34
Copy link

@smithfarm smithfarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smithfarm smithfarm merged commit 6873ed0 into SUSE:ses5 Feb 10, 2017
@kshtsk kshtsk deleted the bc-missing branch September 3, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants