Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple_regular_solve.jl with new function BinomialTauLeaping #412

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

c-louhichi
Copy link

Add a function for binomial tau leaping :)

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@isaacsas
Copy link
Member

isaacsas commented Apr 9, 2024

@ChrisRackauckas maybe it would make sense to allow passing non-regular jump types to regular jump methods too so they can specialize their code? This would allow @c-louhichi to specialize on mass action jump input for now.

@isaacsas
Copy link
Member

isaacsas commented Apr 9, 2024

@c-louhichi can you also update https://github.com/SciML/JumpProcesses.jl/blob/master/test/regular_jumps.jl with an example using / testing the output of your new solver?

@isaacsas
Copy link
Member

isaacsas commented Apr 9, 2024

We probably don't want to have an expression-based analysis here, but let's get a test in and then I can leave more detailed feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants