refactor: disallow additionalProperties in response schemas (#1543)

Unleash · Apr 29, 2022 · c028655 · c028655 · github-actions · Apr 29, 2022
1 parent ec87811
commit c028655
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 0 deletions.
diff --git a/src/lib/openapi/spec/constraint-schema.ts b/src/lib/openapi/spec/constraint-schema.ts
@@ -2,6 +2,7 @@ import { createSchemaObject, CreateSchemaType } from '../types';
 
 export const schema = {
     type: 'object',
+    additionalProperties: false,
     required: ['contextName', 'operator'],
     properties: {
         contextName: {

diff --git a/src/lib/openapi/spec/feature-schema.ts b/src/lib/openapi/spec/feature-schema.ts
@@ -2,6 +2,7 @@ import { createSchemaObject, CreateSchemaType } from '../types';
 
 const schema = {
     type: 'object',
+    additionalProperties: false,
     required: ['name', 'project'],
     properties: {
         name: {

diff --git a/src/lib/openapi/spec/features-schema.ts b/src/lib/openapi/spec/features-schema.ts
@@ -2,6 +2,7 @@ import { createSchemaObject, CreateSchemaType } from '../types';
 
 export const schema = {
     type: 'object',
+    additionalProperties: false,
     required: ['version', 'features'],
     properties: {
         version: {

diff --git a/src/lib/openapi/spec/override-schema.ts b/src/lib/openapi/spec/override-schema.ts
@@ -2,6 +2,7 @@ import { createSchemaObject, CreateSchemaType } from '../types';
 
 export const schema = {
     type: 'object',
+    additionalProperties: false,
     required: ['contextName', 'values'],
     properties: {
         contextName: {

diff --git a/src/lib/openapi/spec/strategy-schema.ts b/src/lib/openapi/spec/strategy-schema.ts
@@ -2,6 +2,7 @@ import { createSchemaObject, CreateSchemaType } from '../types';
 
 export const schema = {
     type: 'object',
+    additionalProperties: false,
     required: ['id', 'name', 'constraints', 'parameters'],
     properties: {
         id: {

diff --git a/src/lib/openapi/spec/variant-schema.ts b/src/lib/openapi/spec/variant-schema.ts
@@ -2,6 +2,7 @@ import { createSchemaObject, CreateSchemaType } from '../types';
 
 export const schema = {
     type: 'object',
+    additionalProperties: false,
     required: ['name', 'weight', 'weightType', 'stickiness', 'overrides'],
     properties: {
         name: {

diff --git a/src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap b/src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap
@@ -52,6 +52,7 @@ Object {
   "components": Object {
     "schemas": Object {
       "constraintSchema": Object {
+        "additionalProperties": false,
         "properties": Object {
           "contextName": Object {
             "type": "string",
@@ -93,6 +94,7 @@ Object {
         "type": "object",
       },
       "featureSchema": Object {
+        "additionalProperties": false,
         "properties": Object {
           "createdAt": Object {
             "format": "date",
@@ -145,6 +147,7 @@ Object {
         "type": "object",
       },
       "featuresSchema": Object {
+        "additionalProperties": false,
         "properties": Object {
           "features": Object {
             "items": Object {
@@ -163,6 +166,7 @@ Object {
         "type": "object",
       },
       "overrideSchema": Object {
+        "additionalProperties": false,
         "properties": Object {
           "contextName": Object {
             "type": "string",
@@ -181,6 +185,7 @@ Object {
         "type": "object",
       },
       "strategySchema": Object {
+        "additionalProperties": false,
         "properties": Object {
           "constraints": Object {
             "items": Object {
@@ -207,6 +212,7 @@ Object {
         "type": "object",
       },
       "variantSchema": Object {
+        "additionalProperties": false,
         "properties": Object {
           "name": Object {
             "type": "string",
St.^❔	Category	Percentage	Covered / Total
🟢	Statements	91.2%	5171/5670
🟡	Branches	79.31%	805/1015
🟢	Functions	86.18%	1216/1411
🟢	Lines	91.12%	5050/5542