Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: invalid HTML and react errors in insights pages (#6593)
This PR fixes these errors (that were showing up in the dev console) in the insights pages: - nesting a div within a p in the count header (flags, environments, apps); instead flip the relationship and nest the p within the div - missing keys in mapped components - passing a boolean "scrolled" value to the underlying component (a div) is invalid: instead, make it so that that prop is not passed The only one of these that could have a visual impact is the first one (p>div -> div>p), but it appears to be the same to me. Here's before the change: ![image](https://github.com/Unleash/unleash/assets/17786332/ffffd3cc-1236-458f-8449-3310b0044f14) And here's after: ![image](https://github.com/Unleash/unleash/assets/17786332/9ad2d8f7-9f9e-492f-932e-a194683b1d75)
- Loading branch information
1 parent
a3d06bd
commit c2015c6
Showing
3 changed files
with
27 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters