[B3] Build fix #25416
Closed
[B3] Build fix #25416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash bd235d5) |
Reviewed by NOBODY (OOPS!). In B3Procedure.h typeAtOffset() calls extractFromTuple() which is only implemented by sub classes. * Source/JavaScriptCore/b3/B3Procedure.h: making typeAtOffset() virtual.
webkit-ews-buildbot
added
the
merging-blocked
sideeffect42
force-pushed
the
b3procedure-build-fix
branch
from
bd235d5
to
0a5cdb8
Compare
|
EWS run on current version of this PR (hash 0a5cdb8) |
mcatanzaro
requested changes
Mar 4, 2024
| @@ -125,7 +125,7 @@ class Procedure { | |||
| JS_EXPORT_PRIVATE const Vector<Type>& tupleForType(Type tuple) const; | |||
|
|
|||
| unsigned resultCount(Type type) const { return type.isTuple() ? tupleForType(type).size() : type.isNumeric(); } | |||
| Type typeAtOffset(Type type, unsigned index) const { ASSERT(index < resultCount(type)); return type.isTuple() ? extractFromTuple(type, index) : type; } | |||
| virtual Type typeAtOffset(Type type, unsigned index) const { ASSERT(index < resultCount(type)); return type.isTuple() ? extractFromTuple(type, index) : type; } | |||
There was a problem hiding this comment.
typeAtOffset is not overridden anywhere, though, so this really shouldn't be virtual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In B3Procedure.h typeAtOffset() calls extractFromTuple() which is only implemented by sub classes.
0a5cdb8
🛠 wincairo🧪 wpe-wk2🧪 api-wpe🛠 gtk🧪 gtk-wk2🛠 tv🧪 api-gtk🛠 tv-sim🛠 jsc-armv7🛠 watch🧪 jsc-armv7-tests🛠 watch-sim