Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[B3] Build fix #25416

Closed
wants to merge 1 commit into from
Closed

[B3] Build fix #25416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/JavaScriptCore/b3/B3Procedure.h
View file
Open in desktop
Expand Up @@ -125,7 +125,7 @@ class Procedure {
JS_EXPORT_PRIVATE const Vector<Type>& tupleForType(Type tuple) const;

unsigned resultCount(Type type) const { return type.isTuple() ? tupleForType(type).size() : type.isNumeric(); }
Type typeAtOffset(Type type, unsigned index) const { ASSERT(index < resultCount(type)); return type.isTuple() ? extractFromTuple(type, index) : type; }
virtual Type typeAtOffset(Type type, unsigned index) const { ASSERT(index < resultCount(type)); return type.isTuple() ? extractFromTuple(type, index) : type; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeAtOffset is not overridden anywhere, though, so this really shouldn't be virtual.


template<typename ValueType, typename... Arguments>
ValueType* add(Arguments...);
Expand Down