Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unsupported disposal methods when decoding GIF #25533

Merged

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Mar 6, 2024

095152b

Ignore unsupported disposal methods when decoding GIF

https://bugs.webkit.org/show_bug.cgi?id=270572

Reviewed by Michael Catanzaro.

Merge: https://chromium.googlesource.com/chromium/blink/+/cdfed72e21acef69547a0266508067d238cd1b06

This fixes potential assertion failure about invalid disposal methods by ignoring
unsupported values when decoding GIF.

The bug is caused by some GIF images containing frames with disposal
method 5. Don't know what the author wanted.

NOTE - Due to lack of 'CPP' tests, I am unable to import test changes.

* Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::parse):

Canonical link: https://commits.webkit.org/275749@main

1cbc600

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
  πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
  πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@Ahmad-S792 Ahmad-S792 added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 6, 2024
@Ahmad-S792 Ahmad-S792 self-assigned this Mar 6, 2024
@Ahmad-S792 Ahmad-S792 marked this pull request as ready for review March 6, 2024 18:20
@Ahmad-S792 Ahmad-S792 added the merge-queue Applied to send a pull request to merge-queue label Mar 6, 2024
https://bugs.webkit.org/show_bug.cgi?id=270572

Reviewed by Michael Catanzaro.

Merge: https://chromium.googlesource.com/chromium/blink/+/cdfed72e21acef69547a0266508067d238cd1b06

This fixes potential assertion failure about invalid disposal methods by ignoring
unsupported values when decoding GIF.

The bug is caused by some GIF images containing frames with disposal
method 5. Don't know what the author wanted.

NOTE - Due to lack of 'CPP' tests, I am unable to import test changes.

* Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::parse):

Canonical link: https://commits.webkit.org/275749@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275749@main (095152b): https://commits.webkit.org/275749@main

Reviewed commits have been landed. Closing PR #25533 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 095152b into WebKit:main Mar 6, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 6, 2024
@Ahmad-S792 Ahmad-S792 deleted the fix-gif-disposal-method branch March 6, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
4 participants