New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore unsupported disposal methods when decoding GIF #25533

Merged

webkit-commit-queue merged 1 commit into WebKit:main from Ahmad-S792:fix-gif-disposal-method

Mar 6, 2024

Commits on Mar 6, 2024

Ignore unsupported disposal methods when decoding GIF

https://bugs.webkit.org/show_bug.cgi?id=270572

Reviewed by Michael Catanzaro.

Merge: https://chromium.googlesource.com/chromium/blink/+/cdfed72e21acef69547a0266508067d238cd1b06

This fixes potential assertion failure about invalid disposal methods by ignoring
unsupported values when decoding GIF.

The bug is caused by some GIF images containing frames with disposal
method 5. Don't know what the author wanted.

NOTE - Due to lack of 'CPP' tests, I am unable to import test changes.

* Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::parse):

Canonical link: https://commits.webkit.org/275749@main

Ahmad-S792 authored and Ahmad Saleem committed Mar 6, 2024