Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION(276012@main): CMake fails with GObject-Introspection disabled #25811

Merged

Conversation

aperezdc
Copy link
Contributor

@aperezdc aperezdc commented Mar 13, 2024

@aperezdc aperezdc self-assigned this Mar 13, 2024
@aperezdc aperezdc added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 13, 2024
https://bugs.webkit.org/show_bug.cgi?id=269377

Reviewed by Michael Catanzaro and Philippe Normand.

* Source/WebKit/PlatformGTK.cmake: Quote the expansion of ${GI_VERSION}
  to ensure VERSION_GREATER_EQUAL has at least an empty string as value
  to compare against; otherwise when the variable is undefined there was
  no left-hand side of the comparison, which resulted in CMake erroring
  due to wrong syntax.

Canonical link: https://commits.webkit.org/276019@main
@webkit-commit-queue
Copy link
Collaborator

Committed 276019@main (3a1c081): https://commits.webkit.org/276019@main

Reviewed commits have been landed. Closing PR #25811 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3a1c081 into WebKit:main Mar 13, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 13, 2024
@aperezdc aperezdc deleted the aperezdc/bug269377-nogi-fix branch April 14, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
5 participants