Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specificity for buttons with outline style and background colors #24599

Merged
merged 3 commits into from Aug 18, 2020
Merged

Fix specificity for buttons with outline style and background colors #24599

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bee1b1
Fix specificity for buttons with outline style and background colors
oandregal Aug 17, 2020
a730cf3
Be more specific
oandregal Aug 18, 2020
8b7cca1
Revert "Be more specific"
oandregal Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/block-library/src/button/style.scss
View file
Open in desktop
Expand Up @@ -41,15 +41,19 @@ $blocks-button__height: 56px;


// the first selector is required for old buttons markup

.wp-block-button.no-border-radius,
.wp-block-button__link.no-border-radius {
border-radius: 0 !important;
}

.is-style-outline .wp-block-button__link,
.wp-block-button.is-style-outline,
.wp-block-button__link.is-style-outline {
color: $dark-gray-700;
background-color: transparent;

oandregal marked this conversation as resolved.
Show resolved Hide resolved
}

.wp-block-button__link.is-style-outline,
.wp-block-button.is-style-outline .wp-block-button__link {
oandregal marked this conversation as resolved.
Show resolved Hide resolved
border: 2px solid;
}