Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12072] Add logic that does not impose any limit when totalCountLimit is less than 0. #12073

Merged
merged 12 commits into from May 15, 2024

Conversation

Happy-26
Copy link
Contributor

@Happy-26 Happy-26 commented May 9, 2024

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是判断<0即可。不一定只能配置成-1

另外帮忙针对改动添加一下UT

@Happy-26 Happy-26 changed the title [ISSUE #12072] Add logic to not impose any limit when totalCountLimit equals -1. [ISSUE #12072] Add logic that does not impose any limit when totalCountLimit is less than 0. May 10, 2024
Add unit test cases when LimitCount is less than 0
@Happy-26
Copy link
Contributor Author

是不是判断<0即可。不一定只能配置成-1

另外帮忙针对改动添加一下UT

已经修改条件为 totalCountLimit < 0, 并添加一个单元测试

@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. plugin labels May 15, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone May 15, 2024
@KomachiSion KomachiSion merged commit 15c9663 into alibaba:develop May 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement. plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants