-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #12072] Add logic that does not impose any limit when totalCountLimit is less than 0. #12073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emented by default in Nacos is one more than the actual number of connections.
修改configChangeRequest.setArg()的key为serviceType
Add logic to not impose any limit when totalCountLimit equals -1.
KomachiSion
requested changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是不是判断<0即可。不一定只能配置成-1
另外帮忙针对改动添加一下UT
Happy-26
changed the title
[ISSUE #12072] Add logic to not impose any limit when totalCountLimit equals -1.
[ISSUE #12072] Add logic that does not impose any limit when totalCountLimit is less than 0.
May 10, 2024
Add unit test cases when LimitCount is less than 0
Modify comment
已经修改条件为 |
KomachiSion
approved these changes
May 15, 2024
KomachiSion
added
kind/enhancement
Category issues or prs related to enhancement.
plugin
labels
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12072