Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 amp-mathml: Add support for non-block mode; fixes #19420 #19436

Merged
merged 7 commits into from Nov 28, 2018

Conversation

KENNYSOFT
Copy link
Member

@KENNYSOFT KENNYSOFT commented Nov 23, 2018

Closes #19420 : <amp-mathml> to support for non-block mode.

The example document with the next source is rendered as the next figure.

  <h2>The Quadratic Formula</h2>
  <amp-mathml
    layout="container"
    data-formula="\[x = {-b \pm \sqrt{b^2-4ac} \over 2a}.\]">
  </amp-mathml>
  <h2>Cauchy's Integral Formula</h2>
  <amp-mathml
    layout="container"
    data-formula="\[f(a) = \frac{1}{2\pi i} \oint\frac{f(z)}{z-a}dz\]">
  </amp-mathml>
  <h2>Double angle formula for Cosines</h2>
  <amp-mathml
    layout="container"
    data-formula="$$ \cos(θ+φ)=\cos(θ)\cos(φ)−\sin(θ)\sin(φ) $$">
  </amp-mathml>
  <h2>Inline formula</h2>
  <p>This is an example of a formula of <amp-mathml layout="container" inline data-formula="`x`"></amp-mathml>, <amp-mathml layout="container" inline data-formula="\(x = {-b \pm \sqrt{b^2-4ac} \over 2a}\)"></amp-mathml> placed inline in the middle of a block of text. <amp-mathml layout="container" inline data-formula="\( \cos(θ+φ) \)"></amp-mathml> This shows how the formula will fit inside a block of text and can be styled with CSS.</p>

image

@KENNYSOFT KENNYSOFT changed the title 🐛 amp-mathml: Add support for non-block mode; fixes #19420 🐛 amp-mathml: Add support for non-block mode; fixes #19420 Nov 23, 2018
@KENNYSOFT
Copy link
Member Author

KENNYSOFT commented Nov 23, 2018

Hmm, have no idea why CI fails... 😢

@aghassemi
Copy link
Contributor

Thanks for the PR! I am currently on vacation and will review when I return middle of next week. Sorry for the delay.

Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Thank you @KENNYSOFT . I will merge as soon as unit test pass( failed due to a flake, I am re-running them now)

@KENNYSOFT
Copy link
Member Author

I see. Thanks for confirming. 😆

@aghassemi aghassemi merged commit fa99cee into ampproject:master Nov 28, 2018
@KENNYSOFT
Copy link
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants