Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1499 Replace indices in function calls with pointers #88

Closed

Conversation

artes-liberales
Copy link
Contributor

#1499 Replace indices in function calls with pointers

Some instances of r_idx are now replaced with pointers.
All of these were in functions working with monster recall.

Also a bug was fixed in the function wipe_monster_lore,
that made it impossible to wipe lore for all monsters.
This wizard command 'W' does not seem to be documented
in the help file.

This is only a partial solution of the ticket. The
remaining r_idx and other indices may still need cleanup.

Changes in:
mon-lore.h
mon-lore.c

In the functions:
cheat_monster_lore (Wizard command r)
wipe_monster_lore (Wizard command W)
describe_monster (Outputs the monster recall)
roff_top (Display one line with the name and ch of the monster)
screen_roff (Recall on the screen)
display_roff (Recall in term window)

Also secondary changes in:
wizard.c (Wizard commands r, W)
xtra3.c (Recall in subwindow)
cmd3.c (One line desc. at the recall command '/')
target.c (Recall when targeting)
ui-knowledge.c (Recall in list after player knowledge command ~)
wiz-spoil.c (Create spoil files)

No changes in:
mon-util.c
In the functions:
summon_specific_ok
What's the header file? The function does not seem to be in use.
I did not understand the function, so I didn't dare to change it.

No changes in:
cave.h
cave.c
In:
monster_race_track

No changes in mon-make.c, generate.c, spells1.c, wizard.c,
because r_idx is used inside the functions

@magnate
Copy link
Member

magnate commented Oct 21, 2011

merged with thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants