Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): add typings files to assist devs #154

Merged
merged 1 commit into from Jan 28, 2016

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Jan 27, 2016

Some editors/IDEs will utilized TypeScript definition files
Adding some useful definitions to assist developers

@filipesilva
Copy link
Contributor

What do you think of using tsd to install and manage these?

A postinstall script in package.json could then install them automatically after the project dependencies are installed.

Edit: I say this in part because I think TSD will have to be used on the generated project to manage typings for the protractor/jasmine e2e tests, since those don't use typings from A2.

@cironunes
Copy link
Member

+1 for using tsd

On Wed, Jan 27, 2016, 5:29 AM Filipe Silva notifications@github.com wrote:

What do you think of using (tsd)[https://github.com/DefinitelyTyped/tsd]
to install and manage these?

A postinstall script in package.json could then install them
automatically after the project dependencies are installed.


Reply to this email directly or view it on GitHub
#154 (comment).

@Brocco
Copy link
Contributor Author

Brocco commented Jan 27, 2016

I have no problem switching to using a tool. But I just heard of a new typings manager yesterday, take a look at https://github.com/typings/typings and I can switch to either this or tsd with a post install script

@filipesilva
Copy link
Contributor

I checked that repo and typings seems nice.

It's own registry is kinda empty but I guess it doesn't make much of a difference since it can install stuff from a lot of places.

I can't find much information about it on the Internet though.

I'm OK either way really, what do you prefer @Brocco?

@Brocco
Copy link
Contributor Author

Brocco commented Jan 27, 2016

I think typings looks interesting as a future goal, but with the state and current direction of the CLI, I think I'll just stick with tsd I'll clean up this PR and re-push it

Are there any other libs I should try to pull in that I may have missed?

@filipesilva
Copy link
Contributor

Can't think of any others right now, no.

Some editors/IDEs will utilized TypeScript definition files
Adding some useful definitions to assist developers
@Brocco
Copy link
Contributor Author

Brocco commented Jan 28, 2016

I ended up going with typings over tsd as tsd has been deprecated in favor of typings (npm install message when upgrading tsd).

type info is now kept in typings.json and will be installed via an npm post install script

@filipesilva filipesilva merged commit 61ec3d6 into angular:master Jan 28, 2016
@filipesilva
Copy link
Contributor

It's in!

Also, for the record, some info on the deprecation can be found in this issue DefinitelyTyped/tsd#269

@Brocco Brocco deleted the typings branch February 18, 2016 01:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants