Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($location) : initialize locationPrototype.$$absUrl to empty string #14488

Closed
wants to merge 1 commit into from
Closed

fix($location) : initialize locationPrototype.$$absUrl to empty string #14488

wants to merge 1 commit into from

Conversation

GuillaumeSalles
Copy link

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Initialize locationPrototype.$$absUrl to avoid a crash when base href and current location have different domains.

What is the current behavior? (You can also link to an open issue here)
#11091

What is the new behavior (if this is a feature change)?
Does not crash anymore.

Does this PR introduce a breaking change?
I don't think so...

Please check if the PR fulfills these requirements

Other information:

Closes #11091

Initialize locationPrototype.$$absUrl to avoid exception when base href
and current location have different dommains.

Closes #11091
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@GuillaumeSalles
Copy link
Author

Hi, I just signed the CLA.

@gkalpak
Copy link
Member

gkalpak commented Apr 22, 2016

Seems reasonable, but one can never be too sure with $location stuff 😛
/cc @petebacondarwin for the final LGTM

(The CLA thing doesn't seem to have worked btw...)

@GuillaumeSalles
Copy link
Author

I signed the CLA with another account. My mistake.
I just signed it again with the right email.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak
Copy link
Member

gkalpak commented Jun 3, 2016

This should also fix #13565.

@petebacondarwin
Copy link
Member

LGTM

@gkalpak gkalpak closed this in b9ac336 Jun 6, 2016
gkalpak pushed a commit that referenced this pull request Jun 6, 2016
Initialize `$$absUrl` to an empty string, in order to avoid exception, when base href
and current location have different domains.

Fixes #11091
Fixes #13565

Closes #14488
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants