Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

style: design homepage wireframe #1090

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

style: design homepage wireframe #1090

wants to merge 1 commit into from

Conversation

pallavithakare28
Copy link

@pallavithakare28 pallavithakare28 commented Sep 4, 2020 •
edited

Description

I have introduced a wireframe design for the homepage namely, design.

Fixes #1034

Type of Change:

  • User Interface

Mocks

Design-1
Design1

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@pallavithakare28
Copy link
Author

pallavithakare28 commented Sep 4, 2020 •
edited

@Kajol-Kumari I have created this new PR, kindly review it, and please let me know your thoughts.

@pallavithakare28 pallavithakare28 mentioned this pull request Sep 4, 2020
Closed
10 tasks
@Kajol-Kumari
Copy link

Hey @pallavithakare28 please do the following:

  1. use the updated logo with don't contain the word Systers in it. You can get it from here
  2. you design needs to clean in terms of proper spacing and don't add news , contacts on the homepage instead we can keep a slider on the home page for showing achievements

@Kajol-Kumari
Copy link

@anitab-org/design-team can you please review this PR

@pallavithakare28
Copy link
Author

@Kajol-Kumari @anitab-org/design-team PR page is showing error 404. Can you please help me

@Kajol-Kumari
Copy link

@Kajol-Kumari @anitab-org/design-team PR page is showing error 404. Can you please help me

@pallavithakare28 sorry but when are you getting 404?

@pallavithakare28
Copy link
Author

@anitab-org/design-team can you please review this PR

Sorry @Kajol-Kumari buti for this PR I am getting a 404

@Kajol-Kumari
Copy link

@anitab-org/design-team can you please review this PR

Sorry @Kajol-Kumari buti for this PR I am getting a 404

Ah, @pallavithakare28 that is not the PR link, that's the way to tag vms's design team to review this PR.

@pallavithakare28
Copy link
Author

pallavithakare28 commented Sep 5, 2020 •
edited

@Kajol-Kumari ok mam and can you please review the description of this PR once? Because I have uploaded a new wireframe design. Please let me know the correction.

keshakaneria
keshakaneria previously approved these changes Sep 6, 2020
View reviewed changes
Copy link
Member

@keshakaneria keshakaneria left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pallavithakare28 @Kajol-Kumari Looks good 👍

@Kajol-Kumari
Copy link

Kajol-Kumari commented Sep 6, 2020 •
edited

@pallavithakare28 please keep the design you are showing in the PR description currently and remove the other one. Also please squash the commits in a single one.

@pallavithakare28
style: design homepage wireframe
2270f3a 
introduced wireframe design for homepage namely, design.
@pallavithakare28
Copy link
Author

pallavithakare28 commented Sep 7, 2020 •
edited

@Kajol-Kumari can you please review the PR as I have removed other designs and also squashed the commits. And also I would like to say thank you for your guidance. Thank you, mam.

@pallavithakare28
Copy link
Author

pallavithakare28 commented Sep 7, 2020 •
edited

@pallavithakare28 @Kajol-Kumari Looks good

@keshakaneria Thank you mam, can you please review this PR?

keshakaneria
keshakaneria approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@keshakaneria keshakaneria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashed! Well done! It's ready to get the final review by maintainers :) 👍

@keshakaneria keshakaneria added the Status: Needs Review PR needs an additional review or a maintainer's review. label Sep 7, 2020
Kajol-Kumari
Kajol-Kumari approved these changes Sep 7, 2020
View reviewed changes
Copy link

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pallavithakare28
Copy link
Author

Hey @Kajol-Kumari minimum how many approval are required to merge this PR? Just asking for a knowledge :)

@keshakaneria
Copy link
Member

Hey @Kajol-Kumari minimum how many approval are required to merge this PR? Just asking for a knowledge :)

It requires minimum 2 reviews. We can change the label to ready to merge i suppose

@keshakaneria keshakaneria added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Sep 22, 2020
SanketDG
SanketDG reviewed Sep 22, 2020
View reviewed changes
Copy link

@SanketDG SanketDG left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would again not honestly merge this, since this is honestly very ephemeral by nature.

This is great work, don't get me wrong, but this PNG file can't be edited on, hence make no sense for the wireframe to be inside the repo.

I'd very much prefer that I have the designs are discussed in the issues and then we implement the design.

@isabelcosta isabelcosta added Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Sep 24, 2020
@pallavithakare28
Copy link
Author

@SanketDG Ok that means there's no meaning of this PR?

@SanketDG
Copy link

Ok that means there's no meaning of this PR?

I should not be the only person taking this decision, this is just my opinion, please feel free to ask on Zulip about this.

I also don't know who to tag for VMS, apologies

@Kajol-Kumari
Copy link

Kajol-Kumari commented Oct 1, 2020 •
edited

Hey @pallavithakare28 so we won't be able to merge this PR but we will consider it while evaluating. So don't worry, your hard work will not go in vain :)

\cc: @satya7289

@pallavithakare28
Copy link
Author

Hey @pallavithakare28 so we won't be able to merge this PR but we will consider it while evaluating. So don't worry, your hard work will not go in vain :)

\cc: @satya7289

Thank you @Kajol-Kumari :)

@alpha2320
Copy link

@SanketDG can i redesign this in figma and adobe xd and then can you merge it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SanketDG SanketDG SanketDG left review comments

@Kajol-Kumari Kajol-Kumari Kajol-Kumari approved these changes

@keshakaneria keshakaneria keshakaneria approved these changes

@gaurivn gaurivn Awaiting requested review from gaurivn

Assignees
No one assigned
Labels
Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Wireframe Design for homepage
6 participants
@pallavithakare28 @Kajol-Kumari @keshakaneria @SanketDG @alpha2320 @isabelcosta