fix: updated logo from systers to anitab.org #1000
Conversation
|
@divyanshugit can you add a screenshot of your work in the PR description |
|
Previously
|
theyashshahs
added
the
Status: Ready to Merge
There was a problem hiding this comment.
@divyanshugit can you fix the logo so it's not "squashed" vertically?
theyashshahs
added
Status: Changes Requested
Updated logo which shows only Anitab-org logo.
|
@mayburgos , @yashshah2820 can you review once ! |
mayburgos
added
Status: Needs Testing
mayburgos
changed the title
|
@divyanshugit can you please add to the PR description how the logo will look like now on the website with your change? |
|
@isabelcosta I have already added that you can preview it #1000 (comment) |
There was a problem hiding this comment.
Looks good @divyanshugit !
I hope we can get 1 more approval and a test and then merge it :)
|
@divyanshugit, can you pls update the branch from where you sent the PR. It's most preferable to not send PRs from develop too, it's fine for now, but next time onwards do send from a branch different from develop. |
|
@gaurivn Okay, I will keep this in my mind from the next time onwards. Thanks for the advice. |
Codecov Report
@@ Coverage Diff @@
## develop #1000 +/- ##
===========================================
+ Coverage 86.93% 87.18% +0.24%
===========================================
Files 85 85
Lines 4057 4057
Branches 237 237
===========================================
+ Hits 3527 3537 +10
+ Misses 458 449 -9
+ Partials 72 71 -1
Continue to review full report at Codecov.
|
|
@devkapilbansal solved in another issue? If that is the case, could you please link it in a comment here. If you mean, merge this, let me know and I can proceed with merging. |
Sorry my bad. Commented on wrong issue |
isabelcosta
dismissed
mayburgos’s stale review
changes were done after review
Description
Deleted previous logo and added a new logo for Volunteer Management System
Fixes #982
Type of Change:
Checklist
Removed Systers logo
My changes generate no new warnings