Automated cherry pick of #2672: Convert NodeName obtained from env var to lowercase on #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the startup scripts force an environment variable to have lowercase node name. This gets complex once we add support to native windows services as they don't get env variables from local shell. An example of startup script is function: Start-AntreaAgent in https://raw.githubusercontent.com/antrea-io/antrea/v1.2.0/hack/windows/Helper.psm1 Signed-off-by: Gurucharan Shetty <gurushetty@google.com>
tnqn
added
the
kind/cherry-pick
Codecov Report
@@ Coverage Diff @@
## release-1.3 #2690 +/- ##
================================================
+ Coverage 41.05% 60.58% +19.53%
================================================
Files 158 285 +127
Lines 19243 23006 +3763
================================================
+ Hits 7900 13938 +6038
+ Misses 10596 7568 -3028
- Partials 747 1500 +753
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
antoninbas
approved these changes
Sep 1, 2021
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #2672 on release-1.3.
#2672: Convert NodeName obtained from env var to lowercase on
For details on the cherry pick process, see the cherry pick requests page.