-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Windows, the hostname in kube-apiserver is in lowercase. #2672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/test-all
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #2672 +/- ##
=======================================
Coverage 60.70% 60.71%
=======================================
Files 285 285
Lines 23003 23006 +3
=======================================
+ Hits 13965 13967 +2
+ Misses 7544 7540 -4
- Partials 1494 1499 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Node name is in lowercase on Linux too. kubelet converts it when reporting nodeName regardless of the platform, and server side API validation requires all metadata.name
are in lower case.
So could we adjust the commit title a little to avoid confusion? e.g. "Convert NodeName got from env var to lowercase on Windows"
Currently, the startup scripts force an environment variable to have lowercase node name. This gets complex once we add support to native windows services as they don't get env variables from local shell. An example of startup script is function: Start-AntreaAgent in https://raw.githubusercontent.com/antrea-io/antrea/v1.2.0/hack/windows/Helper.psm1 Signed-off-by: Gurucharan Shetty <gurushetty@google.com>
I updated the commit subject. Please take a look again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
@tnqn feel free to cherry-pick this to release-1.3 if you think it is a good idea |
/skip-e2e as "TestLegacyAntreaPolicy/TestGroupAuditLogging" failed for known reason and has been fixed in #2683. |
/test-windows-all |
/test-windows-e2e |
/test-windows-networkpolicy |
jenkins-windows-networkpolicy failed due to some certificate issue. And apparently the change is not the cause. Merging it as other windows tests succeeded. |
Currently, the startup scripts force an environment variable
to have lowercase node name. This gets complex once we add
support to native windows services as they don't get
env variables from local shell.
An example of startup script is function: Start-AntreaAgent in
https://raw.githubusercontent.com/antrea-io/antrea/v1.2.0/hack/windows/Helper.psm1
Signed-off-by: Gurucharan Shetty gurushetty@google.com