Progressive onboarding follow partner popover #13591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzucconi
commented
Mar 12, 2024
|
|
||
| const ALERT_ID = PROGRESSIVE_ONBOARDING_ALERTS.alertCreate |
There was a problem hiding this comment.
When this got extracted into it's own package — things got renamed and unfortunately they were named as 'alerts' which conflicts with the notion of these being used for capital-A alerts. So I renamed everything to make logical sense again.
dzucconi
commented
Mar 12, 2024
src/Components/ProgressiveOnboarding/ProgressiveOnboardingPopover.tsx
Outdated
Show resolved
Hide resolved
dzucconi
force-pushed
the
DIA-460-logged-in-user-who-has-never-followed-a-gallery-sees-follow-gallery-popover
branch
from
84d34f2
to
21a62d5
Compare
dzucconi
force-pushed
the
DIA-460-logged-in-user-who-has-never-followed-a-gallery-sees-follow-gallery-popover
branch
from
21a62d5
to
ab1c952
Compare
dzucconi
deleted the
DIA-460-logged-in-user-who-has-never-followed-a-gallery-sees-follow-gallery-popover
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DIA-460 + DIA-461
This introduces a popover for the follow button on partner pages for both logged in and logged out users.
This PR includes a bunch of refactoring to have the code make sense again.