refactor(progressive-onboarding): Swap in new @artsy/dismissible and refactor code #13310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
force-pushed
the
damassi/refactor/swap-progressive-onboarding
branch
from
e81320b
to
1e73c3b
Compare
damassi
force-pushed
the
damassi/refactor/swap-progressive-onboarding
branch
from
1e73c3b
to
10ac610
Compare
dzucconi
reviewed
Dec 21, 2023
| @@ -23543,6 +23571,16 @@ yup@0.32.6: | |||
| property-expr "^2.0.4" | |||
| toposort "^2.0.2" | |||
|
|
|||
| yup@^1.3.3: | |||
There was a problem hiding this comment.
Our version of Yup isn't being deduplicated?
There was a problem hiding this comment.
We're on an older version in force, 0.32. Could upgrade here but not too sure what that would look like in this PR.. probably best for a follow-up
|
Mergin |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
The type of this PR is: Refactor
This PR solves AMBER-404
Description
This updates Force to make use of our new @artsy/dismissible lib, and updates code accordingly.