Fix udev rule filename(s) #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The udev rule filename must match the package name for dh_installudev to recognize it.
There was a problem hiding this comment.
I don't have a package with udev rules to test this change against but I had one comment based on my experience adding Suite3 in #147.
Comment on lines
-1471
to
+1476
| link_func(fname, | ||
| os.path.join(debian_dir, '%s.udev' % debinfo.package)) | ||
| if debinfo.with_python2: | ||
| link_func(fname, | ||
| os.path.join(debian_dir, '%s.udev' % debinfo.package)) | ||
| if debinfo.with_python3: | ||
| link_func(fname, | ||
| os.path.join(debian_dir, '%s.udev' % debinfo.package3)) |
There was a problem hiding this comment.
Have you checked how this will behave when both with_python2 and with_python3 are true? Does it create issues if the udev rules are linked under both package names?
There was a problem hiding this comment.
I have tried this and it works fine; the udev rule file actually has to be present twice (with prefix python- and python3-) in that case to be picked up by both the Python 2 and 3 package.
nuclearsandwich
approved these changes
May 6, 2021
|
Can this be merged then? It would be great to have an stdeb bugfix release since this blocks linux-automation/usbsdmux#37 from being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The udev rule filename must match the package name for dh_installudev to
recognize it.