feat(history): add getOrigin method #7
Conversation
jwahyoung
force-pushed
the
router-get-origin
branch
from
73a9ff0
to
759e91f
Compare
| * Returns the fully-qualified root of the current history object. | ||
| */ | ||
| getAbsoluteRoot(): string { | ||
| throw new Error('History must implement getBaseUrl().'); |
There was a problem hiding this comment.
Error message doesn't match method name
|
@jedd-ahyoung If you can address the comment from @bryanrsmith then pending any other discussion we can probably merge this. |
jwahyoung
force-pushed
the
router-get-origin
branch
from
759e91f
to
14fac4b
Compare
|
This has been updated with a corrected error message. |
|
@bryanrsmith I'll let you decide when to merge this since there are several other PRs that are part of the same logical improvement. |
|
Where are we at with this? We want to get to an RC, so I'd like to get things like this resolved in the next couple of weeks. |
|
@EisenbergEffect, I will look into this personally in the coming week. This 2016-03-19 12:41 GMT-04:00 Rob Eisenberg notifications@github.com:
|
|
@jedd-ahyoung ping |
|
After the modal stuff is done, we really need to get this wrapped up fast. |
|
Status? We need this and dialog issues wrapped in the next week or two at most. You weren't in the meeting...but we are trying to get to RC and this is holding us up.... |
Per aurelia/router#88 we want to be able to generate an absolute URI with the `router.generate()` method. That method relies upon the history module. `getAbsoluteRoot` allows the router to generate a fully-qualified root URL.
jwahyoung
force-pushed
the
router-get-origin
branch
from
14fac4b
to
96b5e6e
Compare
|
@EisenbergEffect This can be merged, along with aurelia/history-browser#22 and aurelia/router#294. The test is failing because of a missing |
|
Ok, great. @bryanrsmith Do you have time to do a quick second look? |
|
lgtm |
Per aurelia/router#88 we want to be able to generate an absolute URI with the
router.generate()method. That method relies upon the history module.getOriginallows the router to generate an absolute URI with the protocol, hostname, and port.