New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[network/p2p] Redesign Push Gossip #2772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
aaronbuchwald
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we have a coreth rc + finalize the default values - this LGTM
StephenButtolph
changed the title
[network/p2p] Cleanup Gossip Implementation
[network/p2p] Redesign Push Gossip
Feb 28, 2024
StephenButtolph
requested review from
abi87,
danlaine and
dhrubabasu
as code owners
February 28, 2024 20:07
StephenButtolph
approved these changes
Feb 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 29, 2024
Does this in a sense reduce network security? |
mboben
pushed a commit
to mboben/avalanchego
that referenced
this pull request
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: ava-labs/coreth#497
Why this should be merged
A network incident was caused by network amplification due to re-push gossip. This removes push gossip for transactions learned about over the p2p network.
How this works
The added parameters to the P-chain and X-chain network configs are:
push-gossip-discarded-cache-size
push-gossip-max-regossip-frequency
push-gossip-frequency
The added parameters to the C-chain config are:
push-gossip-frequency
pull-gossip-frequency
How this was tested