Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[network/p2p] Redesign Push Gossip #2772

Merged
merged 60 commits into from
Feb 29, 2024
Merged

[network/p2p] Redesign Push Gossip #2772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
1714e84
remove accumulator from handler
patrick-ogrady Feb 25, 2024
9c07a02
add more comments
patrick-ogrady Feb 25, 2024
80fb2b4
add Has to set
patrick-ogrady Feb 25, 2024
dee16f9
add placeholder for has use
patrick-ogrady Feb 25, 2024
e7f25bf
spike on gossip push
patrick-ogrady Feb 25, 2024
646cadc
add TODO about memory use
patrick-ogrady Feb 25, 2024
f10ed76
add logic to handle discarded tx churn
patrick-ogrady Feb 25, 2024
5bb3d2e
revert discarded cache
patrick-ogrady Feb 25, 2024
0d48439
periodically prune gossipables
patrick-ogrady Feb 25, 2024
31de4f6
add discarded cache
patrick-ogrady Feb 25, 2024
8201106
add arg for regossip frequency
patrick-ogrady Feb 25, 2024
cd7aaf6
add a TODO
patrick-ogrady Feb 25, 2024
1955a67
add metric for tracking gossipables
patrick-ogrady Feb 25, 2024
4d75df0
nit
patrick-ogrady Feb 25, 2024
ff965db
add TODO for x/p
patrick-ogrady Feb 25, 2024
dc69586
prune in add
patrick-ogrady Feb 26, 2024
2c19996
remove unnecessary newline
patrick-ogrady Feb 26, 2024
7277f63
add more comments
patrick-ogrady Feb 26, 2024
cfd1a3e
pop first
patrick-ogrady Feb 26, 2024
dc2c18e
add more TODOs
patrick-ogrady Feb 26, 2024
09abd32
ensure we track size iteration separately
patrick-ogrady Feb 26, 2024
dae722e
remove prune
patrick-ogrady Feb 26, 2024
ee0356d
add log to gossip
patrick-ogrady Feb 26, 2024
55c65fe
Gossip cleanup suggestions (#2773)
patrick-ogrady Feb 26, 2024
a7e8bf7
cleanup some compilation issues
StephenButtolph Feb 27, 2024
06971d7
comment nits
StephenButtolph Feb 27, 2024
0ef1432
comment nits
StephenButtolph Feb 27, 2024
cd91a1d
nit remove useless continue
StephenButtolph Feb 27, 2024
bcfe2cf
implement Has in AVM
StephenButtolph Feb 27, 2024
9e40b64
push gossip with partial sync
StephenButtolph Feb 27, 2024
a3b824f
remove early gossip
StephenButtolph Feb 27, 2024
5031a6e
nit
StephenButtolph Feb 27, 2024
927cff2
nit move time logic out of the loop
StephenButtolph Feb 27, 2024
35fc54b
fix comment
StephenButtolph Feb 27, 2024
6cbd5b4
finalize P-chain push gossip
StephenButtolph Feb 27, 2024
e1da49f
nit default
StephenButtolph Feb 27, 2024
b616714
nit
StephenButtolph Feb 27, 2024
92fdc35
add comment
StephenButtolph Feb 27, 2024
c9620b9
rename method
StephenButtolph Feb 27, 2024
6ce907b
implement avm
StephenButtolph Feb 27, 2024
b603ee6
move param validation
joshua-kim Feb 27, 2024
ad847dc
nit
joshua-kim Feb 27, 2024
fe14e10
nit
joshua-kim Feb 27, 2024
5de194a
nit
joshua-kim Feb 27, 2024
b4d4d1d
nit
joshua-kim Feb 27, 2024
2b74cfd
nit
joshua-kim Feb 27, 2024
28f1664
remove network interface
joshua-kim Feb 27, 2024
876fc3f
fix typo
joshua-kim Feb 27, 2024
795f6d5
nit
joshua-kim Feb 27, 2024
e76f252
duplicate line
joshua-kim Feb 27, 2024
6d3dfaf
nits
StephenButtolph Feb 27, 2024
4450567
Add test for empty gossip
StephenButtolph Feb 27, 2024
63269d7
gomod
joshua-kim Feb 27, 2024
f2f0e11
lint
joshua-kim Feb 27, 2024
7257cc4
Update coreth to v0.13.1-rc.0
StephenButtolph Feb 28, 2024
5b04b7a
register tracking
patrick-ogrady Feb 28, 2024
648915c
Register metric
StephenButtolph Feb 28, 2024
ed41bef
Merge branch 'gossip-cleanup' of github.com:ava-labs/avalanchego into…
StephenButtolph Feb 28, 2024
1cbea42
Make metrics more fine-grained (#2778)
StephenButtolph Feb 28, 2024
18faf45
update coreth
StephenButtolph Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ go 1.21
require (
github.com/DataDog/zstd v1.5.2
github.com/NYTimes/gziphandler v1.1.1
github.com/ava-labs/coreth v0.13.0-rc.0
github.com/ava-labs/coreth v0.13.1-rc.1
github.com/ava-labs/ledger-avalanche/go v0.0.0-20231102202641-ae2ebdaeac34
github.com/btcsuite/btcd/btcutil v1.1.3
github.com/cockroachdb/pebble v0.0.0-20230209160836-829675f94811
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRF
github.com/allegro/bigcache v1.2.1-0.20190218064605-e24eb225f156 h1:eMwmnE/GDgah4HI848JfFxHt+iPb26b4zyfspmqY0/8=
github.com/allegro/bigcache v1.2.1-0.20190218064605-e24eb225f156/go.mod h1:Cb/ax3seSYIx7SuZdm2G2xzfwmv3TPSk2ucNfQESPXM=
github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8=
github.com/ava-labs/coreth v0.13.0-rc.0 h1:V2l3qj2ek3geKDJAnF2M94mYJK8kg2kePixujfJ0bmk=
github.com/ava-labs/coreth v0.13.0-rc.0/go.mod h1:eUMbBLDhlZASJjcbf0gIcD2GMn2rRRCUxC8MXLt5QQk=
github.com/ava-labs/coreth v0.13.1-rc.1 h1:T838dWZicYXrajXBeLbJTat5rtSXkZisOZ0qcHTEVjM=
github.com/ava-labs/coreth v0.13.1-rc.1/go.mod h1:LzD4pI5AjkPS3r86e36Xpt6PZB2pZ/wUS4Vn8kJwWmY=
github.com/ava-labs/ledger-avalanche/go v0.0.0-20231102202641-ae2ebdaeac34 h1:mg9Uw6oZFJKytJxgxnl3uxZOs/SB8CVHg6Io4Tf99Zc=
github.com/ava-labs/ledger-avalanche/go v0.0.0-20231102202641-ae2ebdaeac34/go.mod h1:pJxaT9bUgeRNVmNRgtCHb7sFDIRKy7CzTQVi8gGNT6g=
github.com/aymerick/raymond v2.0.3-0.20180322193309-b565731e1464+incompatible/go.mod h1:osfaiScAUVup+UC9Nfq76eWqDhXlp+4UYaA8uhTBO6g=
Expand Down