Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized (compiler) warnings #56

Open
charlesgregory opened this issue Dec 22, 2020 · 0 comments
Open

Centralized (compiler) warnings #56

charlesgregory opened this issue Dec 22, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@charlesgregory
Copy link
Contributor

From #55, moved here for separate discussion.

I would also like to see compiler warnings when using direct integer coordinates within the library to indicate a developer may encounter off-by-one errors.

Not sure yet how I feel about this. Could be good, could be super annoying

Could potentially add a dhtslib.warnings. This would contain variables to be set at compile time and also report pragma messages. Then we could report only one (pragma) message? This would prevent excessive messages at compile-time. I would have to look into the whether this could even be done the way I envision it. These warnings could be used to warn if you are using dhtslib in performance mode (if we ever make one).

@charlesgregory charlesgregory added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Dec 22, 2020
@charlesgregory charlesgregory reopened this May 4, 2021
@charlesgregory charlesgregory removed this from the Version v0.13.0+htslib-1.12 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant