New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization fast local variables #3194
Draft
HalidOdat
wants to merge
3
commits into
main
Choose a base branch
from
optimization/fast-local-variables
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
performance
Performance related changes and issues
execution
Issues or PRs related to code execution
vm
Issues and PRs related to the Boa Virtual Machine.
labels
Aug 1, 2023
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3194 +/- ##
==========================================
+ Coverage 49.53% 49.60% +0.06%
==========================================
Files 446 446
Lines 43722 44070 +348
==========================================
+ Hits 21659 21861 +202
- Misses 22063 22209 +146
☔ View full report in Codecov by Sentry. |
HalidOdat
force-pushed
the
optimization/fast-local-variables
branch
from
September 16, 2023 16:05
8f055b5
to
2d454cb
Compare
jedel1043
reviewed
Sep 16, 2023
HalidOdat
force-pushed
the
optimization/fast-local-variables
branch
3 times, most recently
from
September 28, 2023 14:06
933900d
to
fedf269
Compare
HalidOdat
force-pushed
the
optimization/fast-local-variables
branch
2 times, most recently
from
October 4, 2023 12:49
8fa5cb8
to
b7c9230
Compare
HalidOdat
force-pushed
the
optimization/fast-local-variables
branch
from
October 4, 2023 12:53
b7c9230
to
e23ec27
Compare
Blocked on #3490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
Waiting for another code change
execution
Issues or PRs related to code execution
performance
Performance related changes and issues
run-benchmark
Label used to run banchmarks on PRs
vm
Issues and PRs related to the Boa Virtual Machine.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3185
This PR is a WIP, it implements an optimization on function local variables, functions that do not call
eval
directly or variables that are not escaped, we can keep then on the stack after frame pointer and use and offset to index them (index = fp + offset
). This allows us to eliminate the creation of some of the gc collected environments. Which gives us huge performance improvements!Benchmarks
Main
PR
Almost 2x improvment on NavierStokes :)