Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use main stack for calling ordinary functions #3185

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Use main stack for calling ordinary functions #3185

merged 3 commits into from
Aug 11, 2023

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Jul 29, 2023

Depends on #3179

Part of refactoring calling in VM, makes calling ordinary functions use the main stack, also removes return value from CallFrame and places the return value on the stack after the frame pointer.

@HalidOdat HalidOdat added technical debt execution Issues or PRs related to code execution labels Jul 29, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Jul 29, 2023
@HalidOdat HalidOdat requested a review from a team July 29, 2023 17:25
@HalidOdat HalidOdat force-pushed the refactor-run-method branch 2 times, most recently from c6a2ffc to 9a8398a Compare July 30, 2023 17:55
Base automatically changed from refactor-run-method to main July 31, 2023 01:13
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,282 95,282 0
Passed 75,046 75,046 0
Ignored 19,220 19,220 0
Failed 1,016 1,016 0
Panics 0 0 0
Conformance 78.76% 78.76% 0.00%

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3185 (2a22f99) into main (5f70585) will increase coverage by 0.02%.
Report is 16 commits behind head on main.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
+ Coverage   50.40%   50.42%   +0.02%     
==========================================
  Files         436      436              
  Lines       42375    42549     +174     
==========================================
+ Hits        21358    21457      +99     
- Misses      21017    21092      +75     
Files Changed Coverage Δ
boa_engine/src/builtins/eval/mod.rs 64.83% <ø> (ø)
boa_engine/src/bytecompiler/expression/mod.rs 57.00% <0.00%> (+1.12%) ⬆️
boa_engine/src/bytecompiler/function.rs 91.17% <ø> (ø)
boa_engine/src/bytecompiler/mod.rs 66.58% <ø> (-0.95%) ⬇️
boa_engine/src/vm/call_frame/mod.rs 90.47% <ø> (-0.44%) ⬇️
boa_engine/src/vm/opcode/generator/mod.rs 36.07% <71.42%> (+1.01%) ⬆️
boa_engine/src/builtins/generator/mod.rs 38.29% <100.00%> (+1.80%) ⬆️
...rc/bytecompiler/declaration/declaration_pattern.rs 33.53% <100.00%> (-1.65%) ⬇️
boa_engine/src/bytecompiler/jump_control.rs 94.41% <100.00%> (+0.11%) ⬆️
boa_engine/src/bytecompiler/statement/mod.rs 91.17% <100.00%> (+0.26%) ⬆️
... and 4 more

... and 27 files with indirect coverage changes

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty great! Couple comments/questions 😄

boa_engine/src/vm/code_block.rs Outdated Show resolved Hide resolved
boa_engine/src/vm/mod.rs Show resolved Hide resolved
@HalidOdat HalidOdat requested a review from raskad August 11, 2023 16:12
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@raskad raskad added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit a3b4654 Aug 11, 2023
9 checks passed
@HalidOdat HalidOdat deleted the use-one-stack branch August 12, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants