-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use main stack for calling ordinary functions #3185
Conversation
c6a2ffc
to
9a8398a
Compare
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #3185 +/- ##
==========================================
+ Coverage 50.40% 50.42% +0.02%
==========================================
Files 436 436
Lines 42375 42549 +174
==========================================
+ Hits 21358 21457 +99
- Misses 21017 21092 +75
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty great! Couple comments/questions 😄
- Move `return_value` to stack
e7dd37c
to
facc473
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Depends on #3179Part of refactoring calling in VM, makes calling ordinary functions use the main stack, also removes return value from
CallFrame
and places the return value on the stack after the frame pointer.