Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate unethical code. #5759

Closed
wants to merge 1 commit into from
Closed

Eliminate unethical code. #5759

wants to merge 1 commit into from

Conversation

AntoTG
Copy link

@AntoTG AntoTG commented Jun 6, 2020

I believed that brave was a neutral browser, not just another browser that was looking for an economic benefit without user consent.

Resolves

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

I believed that brave was a neutral browser, not just another browser that was looking for an economic benefit without user consent.
@AntoTG AntoTG changed the title Eliminated unethical code. Eliminate unethical code. Jun 6, 2020
@llebout
Copy link

llebout commented Jun 6, 2020

This is scandaleous, Brave teams, remove this malware code now.

Copy link

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge. This is not okay.

@bbondy
Copy link
Member

bbondy commented Jun 8, 2020

@bsclifton
Copy link
Member

bsclifton commented Jun 8, 2020

Short term fix: feature was defaulted to off with #5761 which is on Nightly, Beta is being built now, and will be put on Release channel this upcoming week

Until Release channel build is available, the feature can be disabled by visiting brave://settings/appearance and toggling Show Brave suggested sites in autocomplete suggestions to OFF

Locking conversation since this is not actionable. Questions and comments can be left in brave/brave-browser#10129

@bsclifton bsclifton closed this Jun 8, 2020
@brave brave locked as resolved and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants