Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables Brave suggested sites by default #5761

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Disables Brave suggested sites by default #5761

merged 1 commit into from
Jun 7, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jun 6, 2020

Fixes brave/brave-browser#10131

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.12.x - Nightly milestone Jun 6, 2020
@ryanml ryanml requested review from bbondy and emerick June 6, 2020 23:01
@ryanml ryanml self-assigned this Jun 6, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml
Copy link
Contributor Author

ryanml commented Jun 7, 2020

Tests pass, builds generated, failure unrelated

@ryanml ryanml merged commit 2bd5c45 into master Jun 7, 2020
@ryanml ryanml deleted the fix-10131 branch June 7, 2020 06:07
ryanml added a commit that referenced this pull request Jun 7, 2020
Disables Brave suggested sites by default
ryanml added a commit that referenced this pull request Jun 7, 2020
Disables Brave suggested sites by default
@srirambv
Copy link
Contributor

srirambv commented Jun 8, 2020

Verification passed on

Brave 1.12.5 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Linux
  • Verified on clean install Brave suggested sites setting is disabled by default
  • Verified with setting off, there are no Brave suggested site suggestion show up for various tokens and partners links
  • Verified upgrading from 1.11.27 to 1.12.5 setting is turned off automatically
  • Verified disabling the setting in 1.11.27 and then upgrading to 1.12.5 retains the setting
  • Verified on upgrade with setting disabled, there are no Brave suggested sites suggestions show up for various tokens and partner links

ryanml added a commit that referenced this pull request Jun 8, 2020
Disables Brave suggested sites by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants