Unwinding several ifs used in debug(). Creating simple string templat…

…es instead. Fixes #818
cakephp · Oct 24, 2010 · 02ade65 · 02ade65
1 parent cef9927
commit 02ade65
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 19 deletions.
diff --git a/cake/basics.php b/cake/basics.php
@@ -92,33 +92,39 @@ function uses() {
  */
 	function debug($var = false, $showHtml = false, $showFrom = true) {
 		if (Configure::read('debug') > 0) {
+			$file = '';
+			$line = '';
 			if ($showFrom) {
 				$calledFrom = debug_backtrace();
-				if(defined('CAKEPHP_SHELL')){
-					echo "##########DEBUG##########\n";
-					echo substr(str_replace(ROOT, '', $calledFrom[0]['file']), 1) ;
-					echo ' (line ' . $calledFrom[0]['line'] . ')'."\n";
-				}else{
-					echo '<strong>' . substr(str_replace(ROOT, '', $calledFrom[0]['file']), 1) . '</strong>';
-					echo ' (line <strong>' . $calledFrom[0]['line'] . '</strong>)';
-				}
+				$file = substr(str_replace(ROOT, '', $calledFrom[0]['file']), 1);
+				$line = $calledFrom[0]['line'];
 			}
-			if(!defined('CAKEPHP_SHELL')){
-				echo "\n<pre class=\"cake-debug\">\n";
+			$html = <<<HTML
+<strong>%s</strong> (line <strong>%s</strong>)
+<pre class="cake-debug">
+%s
+</pre>
+HTML;
+			$text = <<<TEXT
+
+%s (line %s)
+########## DEBUG ##########
+%s
+###########################
+
+TEXT;
+			$template = $html;
+			if (php_sapi_name() == 'cli') {
+				$template = $text;
 			}
-
 			$var = print_r($var, true);
 			if ($showHtml) {
 				$var = str_replace('<', '&lt;', str_replace('>', '&gt;', $var));
 			}
-			echo $var . "\n";
-			if(!defined('CAKEPHP_SHELL')){
-				echo "<pre class=\"cake-debug\">\n";
-			}else{
-				echo "#########################\n";
-			};
+			printf($template, $file, $line, $var);
 		}
 	}
+
 if (!function_exists('sortByKey')) {
 
 /**

diff --git a/cake/tests/cases/basics.test.php b/cake/tests/cases/basics.test.php
@@ -585,15 +585,15 @@ public function testDebug() {
 		ob_start();
 			debug('this-is-a-test');
 		$result = ob_get_clean();
-		$pattern = '/.*\>(.+?tests(\/|\\\)cases(\/|\\\)basics\.test\.php|';
+		$pattern = '/(.+?tests(\/|\\\)cases(\/|\\\)basics\.test\.php|';
 		$pattern .= preg_quote(substr(__FILE__, 1), '/') . ')';
 		$pattern .= '.*line.*' . (__LINE__ - 4) . '.*this-is-a-test.*/s';
 		$this->assertPattern($pattern, $result);
 
 		ob_start();
 			debug('<div>this-is-a-test</div>', true);
 		$result = ob_get_clean();
-		$pattern = '/.*\>(.+?tests(\/|\\\)cases(\/|\\\)basics\.test\.php|';
+		$pattern = '/(.+?tests(\/|\\\)cases(\/|\\\)basics\.test\.php|';
 		$pattern .= preg_quote(substr(__FILE__, 1), '/') . ')';
 		$pattern .=	'.*line.*' . (__LINE__ - 4) . '.*&lt;div&gt;this-is-a-test&lt;\/div&gt;.*/s';
 		$this->assertPattern($pattern, $result);