Merge pull request #6766 from robbertnoordzij/fix-offing-eventlisteners

Fix offing all event listeners for a specific event
cakephp · Jun 9, 2015 · 19e5540 · 19e5540
2 parents ca1789a + 7e67fe6
commit 19e5540
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/Event/EventManager.php b/src/Event/EventManager.php
@@ -277,6 +277,10 @@ public function off($eventKey, $callable = null)
             $this->_detachSubscriber($callable, $eventKey);
             return;
         }
+        if ($callable === null && is_string($eventKey)) {
+            unset($this->_listeners[$eventKey]);
+            return;
+        }
         if ($callable === null) {
             foreach (array_keys($this->_listeners) as $name) {
                 $this->off($name, $eventKey);

diff --git a/tests/TestCase/Event/EventManagerTest.php b/tests/TestCase/Event/EventManagerTest.php
@@ -226,6 +226,24 @@ public function testOffFromAll()
         $this->assertEquals([], $manager->listeners('fake.event'));
     }
 
+    /**
+     * Tests off'ing all listeners for an event
+     */
+    public function testRemoveAllListeners()
+    {
+        $manager = new EventManager();
+        $manager->on('fake.event', ['AClass', 'aMethod']);
+        $manager->on('another.event', ['priority' => 1], 'fakeFunction');
+
+        $manager->off('fake.event');
+
+        $expected = [
+            ['callable' => 'fakeFunction']
+        ];
+        $this->assertEquals($expected, $manager->listeners('another.event'));
+        $this->assertEquals([], $manager->listeners('fake.event'));
+    }
+
     /**
      * Tests detaching an event from a event key queue
      *