Implemented FallbackPasswordHasher::needsRehash()

src/Controller/Component/Auth/FallbackPasswordHasher.php

@@ -82,4 +82,15 @@ public function check($password, $hashedPassword) {
 		return false;
 	}
 
+/**
+ * Returns true if the password need to be rehashed, with the first hasher present
+ * in the list of hashers
+ *
+ * @param string $password The password to verify
+ * @return boolean
+ */
+	public function needsRehash($password) {
+		return $this->_hashers[0]->needsRehash($password);
+	}
+
 }

tests/TestCase/Controller/Component/Auth/FallbackPasswordHasherTest.php

@@ -14,20 +14,20 @@
  */
 namespace Cake\Test\TestCase\Controller\Component\Auth;
 
+use Cake\Controller\Component\Auth\FallbackPasswordHasher;
 use Cake\Controller\Component\Auth\SimplePasswordHasher;
 use Cake\Controller\Component\Auth\WeakPasswordHasher;
-use Cake\Controller\Component\Auth\FallbackPasswordHasher;
 use Cake\TestSuite\TestCase;
 
 /**
- * Test case for SimplePasswordHasher
+ * Test case for FallbackPasswordHasher
  *
  */
 class FallbackPasswordHasherTest extends TestCase {
 
 
 /**
- * Tests that only the first hasher is user for hashig a password
+ * Tests that only the first hasher is user for hashing a password
  *
  * @return void
  */
@@ -42,7 +42,7 @@ public function testHash() {
 	}
 
 /**
- * Tests that the check mehthod will chek with configured hashers until a match
+ * Tests that the check method will check with configured hashers until a match
  * is found
  *
  * @return void
@@ -57,4 +57,20 @@ public function testCheck() {
 		$this->assertTrue($hasher->check('foo', $hash));
 		$this->assertTrue($hasher->check('foo', $otherHash));
 	}
+
+/**
+ * Tests that the password only needs to be re-built according to the first hasher
+ *
+ * @return void
+ */
+	public function testNeedsRehash() {
+		$hasher = new FallbackPasswordHasher(['hashers' => ['Simple', 'Weak']]);
+		$weak = new WeakPasswordHasher();
+		$otherHash = $weak->hash('foo');
+		$this->assertTrue($hasher->needsRehash($otherHash));
+
+		$simple = new SimplePasswordHasher();
+		$hash = $simple->hash('foo');
+		$this->assertFalse($hasher->needsRehash($hash));
+	}
 }