Merge branch '3.0-clean-exceptions' of github.com:cakephp/cakephp int…

…o 3.0-clean-exceptions
cakephp · Aug 30, 2014 · 43353c8 · 43353c8
2 parents 5840bf2 + 4ae598d
commit 43353c8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/View/HelperRegistry.php b/src/View/HelperRegistry.php
@@ -61,7 +61,7 @@ public function __isset($helper) {
 
 		try {
 			$this->load($helper);
-		} catch (Error\MissingHelperException $exception) {
+		} catch (Exception\MissingHelperException $exception) {
 			if ($this->_View->plugin) {
 				$this->load($this->_View->plugin . '.' . $helper);
 				return true;

diff --git a/tests/TestCase/View/ViewTest.php b/tests/TestCase/View/ViewTest.php
@@ -543,7 +543,7 @@ public function testGetViewFileNames() {
 /**
  * Test that getViewFileName() protects against malicious directory traversal.
  *
- * @expectedException Cake\Core\Exception\Exception
+ * @expectedException \InvalidArgumentException
  * @return void
  */
 	public function testGetViewFileNameDirectoryTraversal() {
@@ -642,7 +642,7 @@ public function testGetLayoutFileNamePrefix() {
 /**
  * Test that getLayoutFileName() protects against malicious directory traversal.
  *
- * @expectedException Cake\Core\Exception\Exception
+ * @expectedException \InvalidArgumentException
  * @return void
  */
 	public function testGetLayoutFileNameDirectoryTraversal() {
@@ -1479,7 +1479,7 @@ public function testStartBlocksTwice() {
  * Test that an exception gets thrown when you leave a block open at the end
  * of a view.
  *
- * @expectedException \Cake\Core\Exception\Exception
+ * @expectedException \LogicException
  * @return void
  */
 	public function testExceptionOnOpenBlock() {