Return ->data in Request::data(), restore Hash::get(), add test for d…

…ata() call with null

src/Network/Request.php

@@ -966,7 +966,10 @@ public function data($name = null) {
 			$this->data = Hash::insert($this->data, $name, $args[1]);
 			return $this;
 		}
-		return Hash::get($this->data, $name);
+		if ($name !== null) {
+			return Hash::get($this->data, $name);
+		}
+		return $this->data;
 	}
 
 /**

src/Utility/Hash.php

@@ -32,13 +32,13 @@ class Hash {
  * but is faster for simple read operations.
  *
  * @param array $data Array of data to operate on.
- * @param string|array|null $path The path being searched for. Either a dot
+ * @param string|array $path The path being searched for. Either a dot
  *   separated string, or an array of path segments, or null.
  * @param mixed $default The return value when the path does not exist
  * @return mixed The value fetched from the array, or null.
  * @link http://book.cakephp.org/2.0/en/core-utility-libraries/hash.html#Hash::get
  */
-	public static function get(array $data, $path = null, $default = null) {
+	public static function get(array $data, $path, $default = null) {
 		if (empty($data)) {
 			return $default;
 		}
@@ -54,14 +54,11 @@ public static function get(array $data, $path = null, $default = null) {
 		} else {
 			$parts = $path;
 		}
-
-		if ($path !== null) {
-			foreach ($parts as $key) {
-				if (is_array($data) && isset($data[$key])) {
-					$data =& $data[$key];
-				} else {
-					return $default;
-				}
+		foreach ($parts as $key) {
+			if (is_array($data) && isset($data[$key])) {
+				$data =& $data[$key];
+			} else {
+				return $default;
 			}
 		}
 		return $data;

tests/TestCase/Network/RequestTest.php

@@ -1991,6 +1991,9 @@ public function testDataReading() {
 		$result = $request->data('Model');
 		$this->assertEquals($post['Model'], $result);
 
+		$result = $request->data();
+		$this->assertEquals($post, $result);
+
 		$result = $request->data('Model.imaginary');
 		$this->assertNull($result);
 	}