Fix up code review issues.

cakephp · May 15, 2015 · 49b316d · 49b316d
1 parent 454146a
commit 49b316d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Console/ConsoleIo.php b/src/Console/ConsoleIo.php
@@ -392,7 +392,7 @@ public function macro($name, $args = [])
     }
 
     /**
-     * Conveinence wrapper around macro()
+     * Convenience wrapper around macro()
      *
      * @param string $method The macro to invoke.
      * @param array $args The arguments for the macro.

diff --git a/src/Shell/Macro/TableMacro.php b/src/Shell/Macro/TableMacro.php
@@ -32,7 +32,7 @@ protected function _calculateWidths($rows)
         $widths = [];
         foreach ($rows as $line) {
             for ($i = 0, $len = count($line); $i < $len; $i++) {
-                $columnLength = strlen($line[$i]);
+                $columnLength = mb_strlen($line[$i]);
                 if ($columnLength > (isset($widths[$i]) ? $widths[$i] : 0)) {
                     $widths[$i] = $columnLength;
                 }
@@ -58,7 +58,7 @@ protected function _rowSeparator($widths)
     }
 
     /**
-     * Output a row separator.
+     * Output a row.
      *
      * @param array $widths The widths of each column to output.
      * @return void

diff --git a/tests/TestCase/Shell/Macro/TableMacroTest.php b/tests/TestCase/Shell/Macro/TableMacroTest.php
@@ -9,7 +9,7 @@
  *
  * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
  * @link          http://cakephp.org CakePHP Project
- * @since         3.0.0
+ * @since         3.1.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
 namespace Cake\Test\TestCase\Shell\Macro;