Adding tests for querystring reversal.

cakephp · Dec 28, 2009 · 5b78a66 · 5b78a66
1 parent 886cd9e
commit 5b78a66
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/cake/libs/router.php b/cake/libs/router.php
@@ -997,7 +997,7 @@ function reverse($params) {
 		unset($params['pass'], $params['named'], $params['url'], $url['url']);
 		$params = array_merge($params, $pass, $named);
 		if (!empty($url)) {
-			$params['q'] = $url;
+			$params['?'] = $url;
 		}
 		return Router::url($params);
 	}

diff --git a/cake/tests/cases/libs/router.test.php b/cake/tests/cases/libs/router.test.php
@@ -1980,6 +1980,17 @@ function testRouterReverse() {
 		);
 		$result = Router::reverse($params);
 		$this->assertEqual($result, '/eng/posts/view/1');
+
+		$params = array(
+			'lang' => 'eng',
+			'controller' => 'posts',
+			'action' => 'view',
+			'pass' => array(1),
+			'named' => array(),
+			'url' => array('url' => 'eng/posts/view/1', 'foo' => 'bar', 'baz' => 'quu')
+		);
+		$result = Router::reverse($params);
+		$this->assertEqual($result, '/eng/posts/view/1?foo=bar&baz=quu');
 	}
 }